This repository has been archived by the owner on Sep 11, 2024. It is now read-only.
Move mx_EventTile_info out of mx_EventTile:not([data-layout=bubble]) #8994
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
Z-Community-PR
…-layout=bubble]) to mx_EventTile[data-layout=group] Signed-off-by: Suguru Hirahara <luixxiul@users.noreply.github.com>
…ntTile_line from mx_EventTile:not([data-layout=bubble]) to mx_EventTile[data-layout=group] Signed-off-by: Suguru Hirahara <luixxiul@users.noreply.github.com>
Signed-off-by: Suguru Hirahara <luixxiul@users.noreply.github.com>
…for both IRC and modern layout Signed-off-by: Suguru Hirahara <luixxiul@users.noreply.github.com>
…to group layout only Signed-off-by: Suguru Hirahara <luixxiul@users.noreply.github.com>
…ro padding by default) Signed-off-by: Suguru Hirahara <luixxiul@users.noreply.github.com>
Signed-off-by: Suguru Hirahara <luixxiul@users.noreply.github.com>
…on _EventTile.scss Signed-off-by: Suguru Hirahara <luixxiul@users.noreply.github.com>
Signed-off-by: Suguru Hirahara <luixxiul@users.noreply.github.com>
Signed-off-by: Suguru Hirahara <luixxiul@users.noreply.github.com>
luixxiul
commented
Jul 7, 2022
luixxiul
commented
Jul 9, 2022
| @@ -318,8 +336,30 @@ $left-gutter: 64px; | |||
| padding-top: 0px !important; | |||
| } | |||
|
|
|||
| &.mx_EventTile_info .mx_EventTile_line { | |||
| padding-left: calc($left-gutter + 20px); // override padding-left $left-gutter | |||
| &.mx_EventTile_info { | |||
luixxiul
commented
Jul 9, 2022
| @@ -350,33 +390,6 @@ $left-gutter: 64px; | |||
| font-size: $font-14px; | |||
| position: relative; | |||
|
|
|||
| &.mx_EventTile_info { | |||
There was a problem hiding this comment.
For both IRC and modern layouts
luixxiul
commented
Jul 9, 2022
| @@ -424,10 +437,6 @@ $left-gutter: 64px; | |||
| } | |||
|
|
|||
| &[data-layout=irc] { | |||
| .mx_EventTile_info .mx_EventTile_line { | |||
| padding-left: 0; // Override .mx_EventTile:not([data-layout="bubble"]).mx_EventTile_info .mx_EventTile_line | |||
There was a problem hiding this comment.
Because overriding :not() pseudo class is no longer necessary.
Signed-off-by: Suguru Hirahara <luixxiul@users.noreply.github.com>
Signed-off-by: Suguru Hirahara <luixxiul@users.noreply.github.com>
turt2live
requested review from
a team,
duxovni,
SimonBrandner and
robintown
and removed request for
turt2live and
a team
|
except it looks like you have merge conflicts |
|
@robintown Thanks for reviewing. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR moves
mx_EventTile_infoout ofmx_EventTile:not([data-layout=bubble])to prevent an unexpected regression due to:not()pseudo class which has a number of quirks, tricks, and unexpected results that you should be aware of before using it.This PR also aligns avatars and event texts on IRC layout.
Fixes element-hq/element-web#22783
Signed-off-by: Suguru Hirahara luixxiul@users.noreply.github.com
type: defect
Notes: Align avatars and event texts on IRC layout
This change is marked as an internal change (Task), so will not be included in the changelog.